Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline and Cesium Ion Logo #11335

Closed
Kai-W opened this issue Jun 6, 2023 · 4 comments
Closed

Offline and Cesium Ion Logo #11335

Kai-W opened this issue Jun 6, 2023 · 4 comments

Comments

@Kai-W
Copy link

Kai-W commented Jun 6, 2023

I have an Cesium application that should not connect to Ion services. I followed the steps in
https://github.com/CesiumGS/cesium/tree/main/Documentation/OfflineGuide
and still getting a Cesium Ion Logo. This behavior is also present in the offline sandcastle example.
Either something is missing in the docs/example to make it fully offline without Ion or the Cesium Ion logo is not displayed correctly
Additionally the link to the docs in the offline Sandcastle links to old migrated

Sandcastle example:
https://sandcastle.cesium.com/index.html?src=Offline.html

Browser:
Chrome 113

Operating System:
Windows 11

@ggetz
Copy link
Contributor

ggetz commented Jun 7, 2023

Thanks @Kai-W. You can remove the Cesium ion logo if you are not using any Cesium ion services. Though we ask you still credit CesiumJS in your application, it is not strictly required.

I've updated the link in #11342.

@ggetz ggetz closed this as completed Jun 7, 2023
@Kai-W
Copy link
Author

Kai-W commented Jun 12, 2023

I don't like the fact that i have to remove credits like this. Why isn't the default that cesiumjs is the default logo/credit and if an ion service ist accessed the Ion logo gets swapped in.
Besides in the referenced community post the complete credit container gets removed, so attributions like OSM also don't show. Just removing the logo should be the way to go:
.cesium-credit-logoContainer { display: none !important; }

@ggetz
Copy link
Contributor

ggetz commented Jun 12, 2023

@Kai-W It's possible to override the Cesium ion credit with another default credit, like a generic Cesium cresit:

Cesium.CreditDisplay.cesiumCredit = new Cesium.Credit(`<a href="https://cesium.com/" target="_blank"><img src="${Cesium.buildModuleUrl("Assets/Images/cesium_credit.png")}" title="Cesium"/></a>`);

@Kai-W
Copy link
Author

Kai-W commented Jun 12, 2023

Cesium.CreditDisplay.cesiumCredit = null looks like a cleaner solution to remove the logo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants