Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove throttleRequests flag in TerrainProvider and inherited classes #3448

Closed
lilleyse opened this issue Jan 20, 2016 · 3 comments
Closed

Remove throttleRequests flag in TerrainProvider and inherited classes #3448

lilleyse opened this issue Jan 20, 2016 · 3 comments
Labels
good first issue An opportunity for first time contributors

Comments

@lilleyse
Copy link
Contributor

throttleRequests is now replaced by a Request object. For 1.19, the following code

if (!defined(request) || (request === false)) {

can change to

if (!defined(request)) {

in ArcGisImageServerTerrainProvider, CesiumTerrainProvider, and VRTheWorldTerrainProvider.
@pjcozzi pjcozzi added the good first issue An opportunity for first time contributors label Jan 26, 2016
@AmayAgrawal
Copy link
Contributor

Can u give one example of what to change exactly

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 28, 2016

Thanks for the interest, @AmayAgrawal, but let's wait until #3476 is merged.

@pjcozzi pjcozzi mentioned this issue Aug 10, 2016
Merged
1 task
@lilleyse lilleyse added remove in 1.26 and removed good first issue An opportunity for first time contributors remove in 1.25 labels Aug 29, 2016
@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 14, 2017

@lilleyse reminder to label this once 3D Tiles is merged.

@pjcozzi pjcozzi added the good first issue An opportunity for first time contributors label Jul 5, 2017
@lilleyse lilleyse mentioned this issue Sep 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An opportunity for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pjcozzi @lilleyse @mramato @hpinkos @AmayAgrawal