You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After #4281 (webgl-mock-for-tests branch), CI will be able to run all Cesium unit tests. Tests that require WebGL use an empty WebGL stub and skip readPixels and friends expectations - so all the code is ran, but not all of it is verified.
I want to move away from heavily using readPixels tests; those are integration tests with the Cesium renderer and WebGL implementation. Some will still be included in Cesium's test suite, but most tests relying on readPixels can be verified reasonably well with verifying only Cesium code, e.g., with spys, validating DrawCommands, etc. This will lead to a faster, easier to debug, more reliable, and more consistent test suite. Even if it is less precise, readPixels expectations rarely find issues in practice and will still be with the mix TBA.
After #4281 (webgl-mock-for-tests branch), CI will be able to run all Cesium unit tests. Tests that require WebGL use an empty WebGL stub and skip
readPixels
and friends expectations - so all the code is ran, but not all of it is verified.I want to move away from heavily using
readPixels
tests; those are integration tests with the Cesium renderer and WebGL implementation. Some will still be included in Cesium's test suite, but most tests relying onreadPixels
can be verified reasonably well with verifying only Cesium code, e.g., with spys, validatingDrawCommands
, etc. This will lead to a faster, easier to debug, more reliable, and more consistent test suite. Even if it is less precise,readPixels
expectations rarely find issues in practice and will still be with the mix TBA.WebGL
test categoryreadPixels
...and migration as reasonable.Small cleanup
toRender
by addingframebuffer
,renderState
, andepsilon
totoRender
The text was updated successfully, but these errors were encountered: