Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eslint instead of jshint in Sandcastle #5368

Open
mramato opened this issue May 25, 2017 · 1 comment
Open

Use eslint instead of jshint in Sandcastle #5368

mramato opened this issue May 25, 2017 · 1 comment

Comments

@mramato
Copy link
Contributor

mramato commented May 25, 2017

The Sandcastle editor uses a separate set of jshint rules than the eslint rules now being used by Cesium. We should switch Sandcastle over to running eslint in the browser so we can get rid of jsHint completely.

It looks like ESLint currently doesn't work in the browser out of the box, but it appears easily fixable. See this issue for details: eslint/eslint#8348

@thw0rted
Copy link
Contributor

Came here to open a new issue asking for better Sandcastle style checking, and found this. Is it anywhere on the roadmap? Would you consider a more full-featured in-browser editor like maybe https://github.com/microsoft/monaco-editor ? Every time I write a const or let or arrow function in a Sandcastle example it highlights the line as invalid, because it doesn't speak modern ECMAScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants