Post processing #5615

lilleyse · 2017-07-11T20:39:55Z

A start for post processing effects in Cesium. I trimmed down this PR so it only applies to scene post-processing. Per-entity post processing will be ready soon too, but I want to keep this PR a bit simpler.

@byumjin u_depthTexture now works so you can test out SSAO. However it uses the last frustum's depth only! This actually works okay for some situations, but to guarantee that only one frustum is rendered, set scene.farToNearRatio to a large number like 100000000.0.

I'll bump again when this is ready to review.

To-do:

added HBAO and DOF

Added stepsize parameter at DOF

add Bloom(Glow) abd EdgeDetection(Toon) Fixed a HBAO's artifact which draws unexpected lines Glow - http://localhost:8080/Apps/Sandcastle/?src=Hello%20World.html&label=Showcases&gist=d5fd85d0eaec2a91fb9548ec8d8fbea4 Toon - http://localhost:8080/Apps/Sandcastle/?src=Hello%20World.html&label=Showcases&gist=87ac93ad6ac8df9c78894ba242416450

…ternally, and set stages show to true by default

cleaned up improvements for PostProcess Added sandcastles for Bloom and Edge detection Reflected Sean Lilley's review

lilleyse · 2017-10-19T18:05:52Z

Source/Scene/Scene.js

+            // and instead shadowing is built-in. In this case execute the command regularly below.
+            command.derivedCommands.shadows.receiveCommand.execute(context, passState);
+        } else {
+            command.execute(context, passState);


All these changes are just reorganization without code edits. The debug show bounding volume code is just moved to its own function.

lilleyse · 2017-10-19T18:08:51Z

Source/Scene/Scene.js

@@ -300,7 +302,7 @@ define([
        this._globeDepth = globeDepth;
        this._depthPlane = new DepthPlane();
        this._oit = oit;
-        this._fxaa = new FXAA();
+        this._sceneFramebuffer = new SceneFramebuffer();


The FXAA file was renamed to SceneFramebuffer and the FXAA specific stuff was moved to PostProcessLibrary

lilleyse · 2017-10-19T18:12:38Z

Source/Shaders/PostProcessFilters/FXAA.glsl


 const float fxaaQualitySubpix = 0.5;
 const float fxaaQualityEdgeThreshold = 0.125;
 const float fxaaQualityEdgeThresholdMin = 0.0833;

 void main()
 {
+    vec2 fxaaQualityRcpFrame = vec2(1.0) / czm_viewport.zw;


@bagnell you might have to double check if this is correct. I removed the uniform value and just calculate this in the shader. This may be related to the multiple-viewport changes in #5225

Bump - in case this is important.

This is fine for now. This would need to change for multiple viewports, but a lot more work would need to be done to get post-processing per-viewport.

lilleyse · 2017-10-19T18:19:07Z

Source/Scene/PostProcessAmbientocclusionStage.js

@@ -0,0 +1,176 @@
+define([


This file is a placeholder for the AO in #5673

lilleyse · 2017-10-19T19:13:10Z

Quick summary of the code:

A PostProcess takes an input texture and output texture and applies a list of PostProcessStage sequentially. It uses a context-wide texture cache for ping-ponging. But it does not support down-scaled textures.

PostProcessStage contains a fragment shader and custom uniforms.

More complicated effects like AO may require custom stages which "inherit" from PostProcessStage. PostProcessAmbientOcclusionStage for example contains an internal PostProcess that is used to generate the grayscale AO texture. The fragment shader of the stage blends the AO texture with the color texture.

PostProcessCompositeStage is "inherited" from PostProcessStage and is a way to define a stage that contains multiple stages. I don't know if this code is actually used, but its convenient for effects like a blur stage, which would be composed of blurX and blurY stages.

PostProcessLibrary is a global store of post processing stages. PostProcessScene contains a PostProcess with common stages grabbed from PostProcessLibrary (all disabled by default).

lilleyse · 2017-10-19T19:14:46Z

@bagnell @pjcozzi the todo list is up-to-date.

pjcozzi · 2017-10-19T20:57:47Z

CC #5808

bagnell · 2018-04-19T20:36:03Z

@lilleyse updated. This should be ready.

lilleyse · 2018-04-22T18:24:49Z

Looks ready to me. I think this is safe to merge for 1.45 but can push if anyone prefers it wait.

pjcozzi · 2018-04-22T21:07:54Z

If we're confident this is pretty well isolated - taking into account OIT, sun bloom, etc.- and well tested, OK with me to merge for 1.45. Otherwise, let's not take the risk with everything else already going in, e.g., log depth, ion, etc.

mramato · 2018-04-23T13:52:52Z

I'm against this going into 1.45, there's no way it's tested enough.
I think the dev guide needs to cover renderer refactors and features like this to ensure consistent and sufficient testing. For example: Did we test this on all browsers, including ones our team rarely uses like Safari? What about iOS/Android? Did we run through every Sandcastle like we do in release testing? Changes like this PR need to have way more scrutiny.

Example A: IE11 is completely broken in this branch. Cesium Viewer renders a black canvas.

…is unavailable.

bagnell · 2018-05-02T23:54:48Z

@lilleyse This is ready. I fixed the issues in IE and Edge. Depth textures aren't supported in IE so any stage added to the collection that requires a depth texture will not be run. If one stage in a composite won't run, then neither does any stage in the composite (also goes for composites of composites).

Can you review this and #6476 soon? I'd like to merge then as soon as possible so they have a while to sit in master before the next release.

lilleyse · 2018-05-03T13:05:01Z

Add a test that checks that post processing works as expected when depth textures are not supported.

lilleyse · 2018-05-03T13:06:11Z

Should requiresDepthTexture be replaced with a generic isSupported function?

…ure to isSupported.

bagnell · 2018-05-03T19:25:16Z

@lilleyse updated.

lilleyse · 2018-05-03T20:21:54Z

Source/Scene/PostProcessStage.js

+     * @see {Context#depthTexture}
+     * @see {@link http://www.khronos.org/registry/webgl/extensions/WEBGL_depth_texture/|WEBGL_depth_texture}
+     */
+    PostProcessStage.prototype.isSupported = function(context) {


Since it's part of the public API it should probably take scene instead.

Annoyingly, there will probably need to be a duplicate function that takes context, for internal use.

lilleyse · 2018-05-03T20:23:06Z

Source/Scene/PostProcessStage.js

+     * @see {Context#depthTexture}
+     * @see {@link http://www.khronos.org/registry/webgl/extensions/WEBGL_depth_texture/|WEBGL_depth_texture}
+     */
+    PostProcessStage.prototype.isSupported = function(context) {


There are a few areas in the post processing code that check if ao is enabled by checking if depth textures are supported. Those areas should call this function instead.

https://github.com/AnalyticalGraphicsInc/cesium/pull/5615/files#diff-1eed62beb3641796599874a8801c8395R463

https://github.com/AnalyticalGraphicsInc/cesium/pull/5615/files#diff-1eed62beb3641796599874a8801c8395R591

https://github.com/AnalyticalGraphicsInc/cesium/pull/5615/files#diff-faf43159371dc6d497cba9acd00771cdR257

lilleyse · 2018-05-04T15:08:10Z

The new changes look good. I tested in as many browsers as I could (Chrome, Firefox, Edge, IE, Safari) and Safari on an iPad. Internet Explorer ignores unsupported post processing stages correctly. As a final safeguard, it might be good to check isSupported and log a message in the AO/DOF/Edge detection Sandcastle demos so that people using IE or devices without depth textures understand why the post process isn't showing up.

The only artifact that I noticed is AO graininess on the iPad. It used to be worse before 5e11e9e but it's still worth showing what's happening. Whether or not this is something we can fix, I don't know.

Also there is a failing test in CI:

  Scene/PostProcessStageComposite
    ✗ does not run a stage that requires depth textures when depth textures are not supported
	Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
	    at <Jasmine>

…le example.

bagnell · 2018-05-04T20:39:39Z

@lilleyse I fixed the test and updated the Sandcastles to report when a post process isn't supported. I think we should merge this and open a bug for the iOS issue. I'll look at it before the next release. I just want this to sit in master for a while

lilleyse · 2018-05-04T21:09:40Z

Travis failed due to an unrelated failure in makeZipFile. Just in case, I restarted the build and will merge when it passes.

I'll look at #6476 soon as well.

lilleyse · 2018-05-04T22:19:44Z

Ok it passed. Thanks @bagnell!

lilleyse and others added 13 commits July 11, 2017 16:10

Initial post processing

834e8cb

Merge branch 'master' into post-processing-1.0

da6035f

Cleanup

9c8a6d6

Added composite stage

a70d8a2

Added ability to have more complex post process stages

4ad7479

added HBAO and DOF

82600fe

added HBAO and DOF

Added stepsize parameter at DOF

d4cc375

Added stepsize parameter at DOF

Fixed texture caching for singly-nested post process effects

c5dccd4

Ability to create output framebuffer in the postProcess instead of ex…

93ef755

…ternally, and set stages show to true by default

Fix casing on file

266cc7b

Some cleanup

1faf224

clean up and adjust review

bebc134

cleaned up improvements for PostProcess Added sandcastles for Bloom and Edge detection Reflected Sean Lilley's review

pjcozzi mentioned this pull request Sep 2, 2017

Post process framework roadmap #5808

Open

46 tasks

Merge branch 'master' into post-processing-1.0

2f0d796

lilleyse commented Oct 19, 2017

View reviewed changes

lilleyse added 2 commits October 19, 2017 15:24

Merge branch 'master' into post-processing-1.0

b087d6a

Fix indentation

e803419

lilleyse mentioned this pull request Oct 20, 2017

Renderer roadmap #3001

Open

24 tasks

bagnell added 5 commits October 20, 2017 15:40

Update Sandcastle examples.

a553d45

Move AO generate shader to its own GLSL file.

213b2c3

Move AO shaders to GLSL files.

0784d5e

Generate random texture at run time.

66c2da7

More clean up from review.

014e660

Fix resizing post process framebuffers.

8a5bef0

bagnell added 6 commits May 1, 2018 14:53

Merge branch 'master' into post-processing-1.0

55ae1a1

Fix silhouette in Edge.

6682e22

Fix blank screen and FXAA in IE.

f6d3654

Do not execute stages that require a depth texture and the extension …

a68418c

…is unavailable.

Fix crash when the Sun is visible after last commit.

1928b7f

Merge branch 'master' into post-processing-1.0

b9b8e0c

Update tests to check for depth textures and change requiresDepthText…

8d6ad17

…ure to isSupported.

lilleyse commented May 3, 2018

View reviewed changes

bagnell and others added 3 commits May 3, 2018 17:08

Updates from review.

6e53e43

Modify random value texture sampling.

5e11e9e

Merge branch 'master' into post-processing-1.0

4468f92

bagnell added 3 commits May 4, 2018 16:17

Fix failing test.

84e242a

Add console warning when a post process isn't supported in a Sandcast…

3534c15

…le example.

Fix failing test.

12c79e7

lilleyse merged commit 13998f2 into master May 4, 2018

bagnell mentioned this pull request May 15, 2018

Fix uniform map name for color copy. #6590

Merged

bagnell deleted the post-processing-1.0 branch June 4, 2018 21:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Post processing #5615

Post processing #5615

lilleyse commented Jul 11, 2017 •

edited by bagnell

lilleyse Oct 19, 2017

lilleyse Oct 19, 2017

lilleyse Oct 19, 2017

lilleyse Feb 5, 2018

bagnell Feb 6, 2018

lilleyse Oct 19, 2017

lilleyse commented Oct 19, 2017

lilleyse commented Oct 19, 2017

pjcozzi commented Oct 19, 2017

bagnell commented Apr 19, 2018

lilleyse commented Apr 22, 2018

pjcozzi commented Apr 22, 2018

mramato commented Apr 23, 2018

bagnell commented May 2, 2018

lilleyse commented May 3, 2018

lilleyse commented May 3, 2018 •

edited

bagnell commented May 3, 2018

lilleyse May 3, 2018

lilleyse May 3, 2018

lilleyse May 3, 2018

lilleyse commented May 4, 2018 •

edited

bagnell commented May 4, 2018

lilleyse commented May 4, 2018

lilleyse commented May 4, 2018

Post processing #5615

Post processing #5615

Conversation

lilleyse commented Jul 11, 2017 • edited by bagnell

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lilleyse commented Oct 19, 2017

lilleyse commented Oct 19, 2017

pjcozzi commented Oct 19, 2017

bagnell commented Apr 19, 2018

lilleyse commented Apr 22, 2018

pjcozzi commented Apr 22, 2018

mramato commented Apr 23, 2018

bagnell commented May 2, 2018

lilleyse commented May 3, 2018

lilleyse commented May 3, 2018 • edited

bagnell commented May 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lilleyse commented May 4, 2018 • edited

bagnell commented May 4, 2018

lilleyse commented May 4, 2018

lilleyse commented May 4, 2018

lilleyse commented Jul 11, 2017 •

edited by bagnell

lilleyse commented May 3, 2018 •

edited

lilleyse commented May 4, 2018 •

edited