Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could cesium add the technique "_3DTILESDIFFUSE" when using extension "KHR_materials_pbrSpecularGlossiness" #8396

Closed
hanaimin opened this issue Nov 14, 2019 · 2 comments

Comments

@hanaimin
Copy link

Hi,
I generate my glTF material with "KHR_materials_pbrSpecularGlossiness" extension. but this extension not allow using "Cesium.Cesium3DTileColorBlendMode.REPLACE" because of no "_3DTILESDIFFUSE" generated automaticaly.

the processPbrMaterials.js code logic may be here:
var baseColorUniform = defaultValue(techniqueUniforms.u_baseColorTexture, techniqueUniforms.u_baseColorFactor);
if (defined(baseColorUniform)) {
baseColorUniform.semantic = '_3DTILESDIFFUSE';
}

Could cesium add the feature for supporting "Replace" color blend mode when using "KHR_materials_pbrSpecularGlossiness" extension?

@OmarShehata
Copy link
Contributor

This sounds like it should be an easy fix that should have gone in the initial spec gloss PR #7006.

@hanaimin if you can put together a Sandcastle example testing this, and open a PR to fix it, we'd be happy to review it!

@j9liu
Copy link
Contributor

j9liu commented Aug 19, 2022

I'm closing this issue since Model no longer supports techniques as of the 1.97 release.

@j9liu j9liu closed this as completed Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants