Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review npm dependencies #178

Closed
5 tasks done
mramato opened this issue Oct 25, 2016 · 2 comments
Closed
5 tasks done

Review npm dependencies #178

mramato opened this issue Oct 25, 2016 · 2 comments
Labels
good first issue An opportunity for first time contributors

Comments

@mramato
Copy link
Contributor

mramato commented Oct 25, 2016 •
edited
Loading

  • Since we depend on bluebird, there's no reason to also depend on promise
  • fs-extra means we don't need mkdirp
  • There's no good reason to depend on underscore
  • object-values is literally 11 lines of code and provides no useful benefit
  • I'm pretty sure datauri usage is unnecessary and can be replaced with one line of code.

There might be more, but this is good low hanging fruit for anyone looking to contribute.
@pjcozzi pjcozzi added the good first issue An opportunity for first time contributors label Oct 31, 2016
@lilleyse lilleyse mentioned this issue Oct 31, 2016
Closed
8 tasks
@lasalvavida
Copy link
Contributor

lasalvavida commented Nov 11, 2016 •
edited
Loading

object-values and underscore were removed in #162.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 3, 2017

Tasklist is complete.

Please reopen if other libraries should be replaced.

@pjcozzi pjcozzi closed this as completed Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An opportunity for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjcozzi @mramato @lasalvavida