Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After optimizations, meshes with greater than 65535 vertices still written to ushort buffer. #230

Closed
tfili opened this issue Jan 25, 2017 · 4 comments
Closed

After optimizations, meshes with greater than 65535 vertices still written to ushort buffer. #230

tfili opened this issue Jan 25, 2017 · 4 comments
Labels
bug

Comments

@tfili
Copy link

tfili commented Jan 25, 2017

This causes an exception in node. I'm seeing the issue in combinePrimitives.
@pjcozzi pjcozzi added the bug label Jan 26, 2017
@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 26, 2017

With glTF 2.0, we can use uint32.

@likangning93
Copy link
Contributor

@pjcozzi do you think it's worthwhile in the meantime to have combinePrimitives check if combining will exceed uint16?

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 18, 2017

Yes, let's check for glTF 1.0.

CC @lasalvavida

@likangning93
Copy link
Contributor

I'm checking this out now, in case anyone else was working on it.

@likangning93 likangning93 mentioned this issue Feb 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjcozzi @tfili @likangning93