Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generating face normals may leave some extra data around #299

Closed
tfili opened this issue Jul 6, 2017 · 1 comment
Closed

generating face normals may leave some extra data around #299

tfili opened this issue Jul 6, 2017 · 1 comment
Labels

Comments

@tfili
Copy link

tfili commented Jul 6, 2017

It looks like the original position data may not be cleared.

Also the test generates face normals if they do not exist doesn't actually test anything, because smooth normals are generated in a previous test. We need to set these tests up to use fresh copies of the models.

@tfili tfili changed the title generateNormalsSpec has some bad tests generating face normals may leave some extra data around Jul 6, 2017
@likangning93
Copy link
Contributor

Also the test `generates face normals if they do not exist doesn't actually test anything

Woah, looks like there's errors in this code path that must have slipped by because of this: https://github.com/AnalyticalGraphicsInc/gltf-pipeline/blob/master/lib/generateNormals.js#L99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants