Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sounding Rocket Storage patch is not working right #31

Open
harveyt opened this issue Oct 15, 2022 · 2 comments
Open

Sounding Rocket Storage patch is not working right #31

harveyt opened this issue Oct 15, 2022 · 2 comments

Comments

@harveyt
Copy link

harveyt commented Oct 15, 2022

%MODULE //HardDrive to hold it
{
        name = HardDrive

This will apply to the first module, which is usually the ModuleCommand, so things get garbled like so (from MM cache):

		MODULE
		{
			name = ModuleCommand
			minimumCrew = 0
			hasHibernation = false
			name = HardDrive
			title = Sounding Rocket Storage
			experiment_id = sss_soundingRocketPayload
			dataCapacity = 0.25
			sampleCapacity = 1
			RESOURCE
			{
				name = ElectricCharge
				rate = 0.020
			}
		}

From sss_SoundingRocketCore, probably affects a few others (CNAR, Taerobee) and might be related to and/or fix #28

Fix is to remove the "name = " and use a filter selection:

%MODULE[HardDrive]
{
@harveyt
Copy link
Author

harveyt commented Oct 15, 2022

Also probably should change each field to "%xxx = y" as it looks like something else may be adding a HardDrive first. It'll be benign but the MM cache with above fix has multiple fields like title, dataCapacity, sampleCapacity.

The above bug may also explain why some early rockets don't show deltaV and/or behave strangely as they probably don't end up with a command module?

@CessnaSkyhawk
Copy link
Owner

Alrighty - thanks for the heads up, that should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants