-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic patch for yet unsupported parts #10
Comments
Well, I assume the beforementioned approach is overcomplicated, because you create RDNode IDs with distinctive names, so it's easier and faster to create a patch that runs after the dedicated support patches and just checks for all parts with stockish and CTTish TechRequired names and renames them accordingly. Like
etc. |
This would make the following patch obsolete
|
I will look at doing this at some point in the future - for now though, I need to keep the current system as the debug patch is part of how I process new part mods (I use it to identify parts which haven't been supported/had errors in their patches). If you, or anyone else has any recommendations for where specific nodes should be patched to, feel free to mention it here, and I'll take it into account when I finally clean it all up. |
Will ideally look into this at some point |
A patch that runs after the support patches and renames stockish and CTTish tech tree node IDs inside those parts to SkyhawkScienceSystem node IDs to have a basic compatibility.
To achieve that, all parts that are patched by the support patches should get a temporary variable, so the generic patch that comes afterwards only patches those parts without that variable.
Then it checks for all stock / CTT nodes and renames them to the according SkyhawkScienceSystem node IDs.
Finally it deletes all those temporary variables - or not, to avoid wasting MM patching time.
The text was updated successfully, but these errors were encountered: