Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAS module added to almost everything #77

Open
harveyt opened this issue Mar 19, 2023 · 0 comments
Open

SAS module added to almost everything #77

harveyt opened this issue Mar 19, 2023 · 0 comments

Comments

@harveyt
Copy link

harveyt commented Mar 19, 2023 •
edited

SkyhawkScienceSystem/Patches/Control/SASUpgrades.cfg

Line 39 in 56f0f35

@PART[*]:HAS[!MODULE[ModuleCommand]]:FOR[zzzSkyhawkScienceSystem]

The original intent was to upgrade the ModuleSAS even if there was no module command, but the HAS is missing the "has ModuleSAS" so it gets applied to anything without a ModuleCommand.

The line should read:

@PART[*]:HAS[@MODULE[ModuleSAS],!MODULE[ModuleCommand]]:FOR[zzzSkyhawkScienceSystem]

Introduced by:

https://github.com/CessnaSkyhawk/SkyhawkScienceSystem/blob/56f0f3561134f6a8f823f16468692df641c764a1/Patches/Control/SASUpgrades.cfg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harveyt