Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial Discretization is incorrect for FFT application #7

Open
Ceyron opened this issue Jun 5, 2022 · 0 comments
Open

Spatial Discretization is incorrect for FFT application #7

Ceyron opened this issue Jun 5, 2022 · 0 comments

Comments

@Ceyron
Copy link
Owner

Ceyron commented Jun 5, 2022

In these three small simulation scripts:

the Fast Fourier Transformation (FFT) was used slightly incorrectly. When setting up the spatial mesh, points on both ends of the boundary are included. That introduces noise and aliasing because the domain is no longer its original size, but slightly larger. See also PR #6.

The fix proposed in PR #6 should also work here, but it would require some additional changes to the code in order to make subsequent operations work as well. Most importantly, the interpolation part of the semi-lagrangian advection scheme would require slight rethinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant