Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTC/CAIP-10 example doesn't match text - P2SH versus P2PKH #87

Open
bumblefudge opened this issue Sep 5, 2023 · 0 comments
Open

BTC/CAIP-10 example doesn't match text - P2SH versus P2PKH #87

bumblefudge opened this issue Sep 5, 2023 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested

Comments

@bumblefudge
Copy link
Collaborator

The Rationale section says P2SH address types map well enough to EVM accounts for the purposes of CAIP-10 interop, but the examples start with 1 and are thus P2PKH addresses.

https://bitbox.swiss/blog/what-are-bitcoin-address-types/

Also, the regexp doesn't constrain the first byte of the address with an enum, and probably should if only certain BTC address types are valid...

Speaking of which, what about taproot and segwit addresses?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant