Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat: set default headless mode #239

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

Lykhoyda
Copy link
Contributor

Set headless version true as a default parameter
Short description of work done

PR Checklist

  • I have run linter locally
  • I have run unit and integration tests locally
    • Update configuration the newest version (readme and const)
  • Rebased to master branch / merged master

Changes

  • EXAMPLE - Removed basic auth from the controller

Issues

Closes #

Copy link
Contributor

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that headless option can be "merged", I don't see the point of having it separated

@Lykhoyda Lykhoyda self-assigned this Jan 12, 2023
@Lykhoyda
Copy link
Contributor Author

I think that headless option can be "merged", I don't see the point of having it separated

I didn't get your idea. Do you mean making it a parameter outside the puppeteer and playwright configuration? As a generic for both?

@BeroBurny
Copy link
Contributor

I think that headless option can be "merged", I don't see the point of having it separated

I didn't get your idea. Do you mean making it a parameter outside the puppeteer and playwright configuration? As a generic for both?

yup

@Lykhoyda Lykhoyda force-pushed the lykhoyda/set_default_headless_parameter branch from e73dab5 to b10e879 Compare January 13, 2023 10:26
Copy link
Contributor

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants