-
Notifications
You must be signed in to change notification settings - Fork 151
Conversation
Woops, accidentally marked as ready |
|
||
type( | ||
selector: string, | ||
text: string, | ||
options?: { delay: number } | ||
): Promise<void>; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already type
inside DappeteerElementHandle
Lines 1 to 11 in d7c51f9
export interface DappeteerElementHandle< | |
Source = unknown, | |
Element = HTMLElement | |
> { | |
$$(selector: string): Promise<DappeteerElementHandle[]>; | |
evaluate(fn: (e: Element) => void | Promise<void>): Promise<void>; | |
type(value: string): Promise<void>; | |
click(): Promise<void>; | |
hover(): Promise<void>; | |
getSource(): Source; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BeroBurny I see, but honestly, I like to have a "type" method on top level as well, I think the code looks more intuitive:
const accountNameInput = await page.$(".new-account-create-form__input");
await accountNameInput.type(accountName);
or
await page.type(".new-account-create-form__input", accountName);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open it as a question for other members to see and left a opinion
cc @irubido @mpetrunic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Short description of work done
PR Checklist
Changes
Issues
Closes #26