Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat: create account method #253

Merged
merged 7 commits into from
Jan 26, 2023
Merged

Conversation

Lykhoyda
Copy link
Contributor

Short description of work done

PR Checklist

  • I have run linter locally
  • I have run unit and integration tests locally
    • Update configuration the newest version (readme and const)
  • Rebased to master branch / merged master

Changes

  • EXAMPLE - Removed basic auth from the controller

Issues

Closes #26

@Lykhoyda Lykhoyda marked this pull request as draft January 20, 2023 11:43
@mpetrunic mpetrunic marked this pull request as ready for review January 20, 2023 12:47
@mpetrunic
Copy link
Member

Woops, accidentally marked as ready

@BeroBurny BeroBurny marked this pull request as draft January 20, 2023 12:51
@Lykhoyda Lykhoyda marked this pull request as ready for review January 25, 2023 10:35
Comment on lines +88 to 94

type(
selector: string,
text: string,
options?: { delay: number }
): Promise<void>;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already type inside DappeteerElementHandle

export interface DappeteerElementHandle<
Source = unknown,
Element = HTMLElement
> {
$$(selector: string): Promise<DappeteerElementHandle[]>;
evaluate(fn: (e: Element) => void | Promise<void>): Promise<void>;
type(value: string): Promise<void>;
click(): Promise<void>;
hover(): Promise<void>;
getSource(): Source;
}

Copy link
Contributor Author

@Lykhoyda Lykhoyda Jan 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BeroBurny I see, but honestly, I like to have a "type" method on top level as well, I think the code looks more intuitive:

      const accountNameInput = await page.$(".new-account-create-form__input");
      await accountNameInput.type(accountName);

or

await page.type(".new-account-create-form__input", accountName);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open it as a question for other members to see and left a opinion
cc @irubido @mpetrunic

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Account method
4 participants