Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat!: Deprecate snap_confirm and implement snap_dialog #277

Merged
merged 9 commits into from
Feb 13, 2023
Merged

feat!: Deprecate snap_confirm and implement snap_dialog #277

merged 9 commits into from
Feb 13, 2023

Conversation

BeroBurny
Copy link
Contributor

Short description of work done

PR Checklist

  • I have run linter locally
  • I have run unit and integration tests locally
    • Update configuration the newest version (readme and const)
  • Rebased to master branch / merged master

Changes

  • EXAMPLE - Removed basic auth from the controller

Issues

Closes #272

Lykhoyda
Lykhoyda reviewed Feb 10, 2023
View reviewed changes
docs/API.md Outdated Show resolved Hide resolved
@BeroBurny
Copy link
Contributor Author

BLOCKER needs MetaMask version 10.25.0

@BeroBurny BeroBurny marked this pull request as ready for review February 10, 2023 19:51
@BeroBurny BeroBurny added this pull request to the merge queue Feb 13, 2023
Merged via the queue into master with commit 23a0121 Feb 13, 2023
@BeroBurny BeroBurny deleted the beroburny/snap-dialog branch February 13, 2023 19:59
@github-actions github-actions bot mentioned this pull request Feb 13, 2023
Merged
This was referenced May 2, 2023
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Lykhoyda Lykhoyda Lykhoyda approved these changes

@irubido irubido Awaiting requested review from irubido irubido is a code owner

@mpetrunic mpetrunic Awaiting requested review from mpetrunic mpetrunic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate snap_confirm and implement snap_dialog
2 participants
@BeroBurny @Lykhoyda