Merge pull request #84 from ChainSafe/cayman/disable-enr-update

disable enr update
ChainSafe · Aug 7, 2020 · 62eaa1b · 62eaa1b
2 parents ef3cab2 + 0244773
commit 62eaa1b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 10 deletions.
diff --git a/src/config/index.ts b/src/config/index.ts
@@ -8,6 +8,10 @@ export type IDiscv5Config = ISessionConfig &
      * defined in milliseconds
      */
     pingInterval: number;
+    /**
+     * Whether to enable enr auto-updating
+     */
+    enrUpdate: boolean;
   };
 
 export const defaultConfig: IDiscv5Config = {
@@ -18,4 +22,5 @@ export const defaultConfig: IDiscv5Config = {
   lookupParallelism: 3,
   lookupNumResults: 16,
   pingInterval: 300 * 1000,
+  enrUpdate: true,
 };
diff --git a/src/service/service.ts b/src/service/service.ts
@@ -517,16 +517,20 @@ export class Discv5 extends (EventEmitter as { new (): Discv5EventEmitter }) {
     if (!this.retrieveRequest(srcId, message)) {
       return;
     }
-    this.addrVotes.addVote(
-      srcId,
-      Multiaddr(`/${isIp.v4(message.recipientIp) ? "ip4" : "ip6"}/${message.recipientIp}/udp/${message.recipientPort}`)
-    );
-    const currentAddr = this.enr.multiaddrUDP;
-    const votedAddr = this.addrVotes.best(currentAddr);
-    if ((currentAddr && votedAddr && !votedAddr.equals(currentAddr)) || (!currentAddr && votedAddr)) {
-      log("Local ENR (IP & UDP) updated: %s", votedAddr);
-      this.enr.multiaddrUDP = votedAddr;
-      this.emit("multiaddrUpdated", votedAddr);
+    if (this.config.enrUpdate) {
+      this.addrVotes.addVote(
+        srcId,
+        Multiaddr(
+          `/${isIp.v4(message.recipientIp) ? "ip4" : "ip6"}/${message.recipientIp}/udp/${message.recipientPort}`
+        )
+      );
+      const currentAddr = this.enr.multiaddrUDP;
+      const votedAddr = this.addrVotes.best(currentAddr);
+      if ((currentAddr && votedAddr && !votedAddr.equals(currentAddr)) || (!currentAddr && votedAddr)) {
+        log("Local ENR (IP & UDP) updated: %s", votedAddr);
+        this.enr.multiaddrUDP = votedAddr;
+        this.emit("multiaddrUpdated", votedAddr);
+      }
     }
 
     // Check if we need to request a new ENR