Merge pull request #116 from ChainSafe/P0/strictNullChecks

add strictNullChecks to tsconfig.json
ChainSafe · Apr 29, 2021 · 7f2d5ef · 7f2d5ef
2 parents d870cfb + 4b99ba3
commit 7f2d5ef
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -0,0 +1,25 @@
+name: Tests
+
+on: [pull_request, push]
+
+jobs:
+  tests:
+    name: Tests
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        node: [12, 14, 15]
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v2-beta
+        with:
+          node-version: ${{matrix.node}}
+      - run: yarn install
+      - run: yarn build
+      - name: Lint
+        run: yarn lint
+      - name: Check Types
+        run: yarn run check-types
+      - name: Unit tests
+        run: yarn test
diff --git a/tsconfig.json b/tsconfig.json
@@ -26,7 +26,7 @@
     /* Strict Type-Checking Options */
     "strict": true,                           /* Enable all strict type-checking options. */
     // "noImplicitAny": true,                 /* Raise error on expressions and declarations with an implied 'any' type. */
-    // "strictNullChecks": true,              /* Enable strict null checks. */
+    "strictNullChecks": true,              /* Enable strict null checks. */
     // "strictFunctionTypes": true,           /* Enable strict checking of function types. */
     // "strictBindCallApply": true,           /* Enable strict 'bind', 'call', and 'apply' methods on functions. */
     // "strictPropertyInitialization": true,  /* Enable strict checking of property initialization in classes. */