Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libp2p] Implement bitswap query timeout mechanism #2398

Closed
hanabi1224 opened this issue Jan 9, 2023 · 2 comments · Fixed by #2399
Closed

[libp2p] Implement bitswap query timeout mechanism #2398

hanabi1224 opened this issue Jan 9, 2023 · 2 comments · Fixed by #2399
Assignees
@hanabi1224

Comments

@hanabi1224
Copy link
Contributor

hanabi1224 commented Jan 9, 2023 •
edited

Issue summary

Currently when outgoing bitswap queries get no response, we don't cancel the queries thus the query ids are kept forever in the internal HashMaps, we should implement timeout mechanism and cleanup stale query ids

Other information and links

#2395 (comment)
@hanabi1224 hanabi1224 self-assigned this Jan 9, 2023
@elmattic
Copy link
Contributor

elmattic commented Jan 9, 2023

Nice, is this an issue with rust bitswap crate, or rather a misuse of the API on our side?

@hanabi1224 hanabi1224 mentioned this issue Jan 9, 2023
Merged
4 tasks
@hanabi1224
Copy link
Contributor Author

hanabi1224 commented Jan 9, 2023 •
edited

Nice, is this an issue with rust bitswap crate, or rather a misuse of the API on our side?

I would categorize this issue as the latter, although ideally, libp2p protocols should have a built-in timeout mechanism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanabi1224 hanabi1224

Labels
None yet
Projects
Forest 🌲 Board [depreciated]
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bitswap query timeout ChainSafe/forest
2 participants
@hanabi1224 @elmattic