Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using ParityDB by default #2576

Closed
3 tasks
lemmih opened this issue Feb 21, 2023 · 5 comments · Fixed by #2606
Closed
3 tasks

Switch to using ParityDB by default #2576

lemmih opened this issue Feb 21, 2023 · 5 comments · Fixed by #2606
Assignees

Comments

@lemmih
Copy link
Contributor

lemmih commented Feb 21, 2023

Issue summary

ParityDB performs better and uses less memory than RocksDB. Let's use it by default.

  • Update build files in Forest.
  • Make sure our docker files don't install unnecessary dependencies.
  • Update the CHANGELOG.

Other information and links

@lemmih
Copy link
Contributor Author

lemmih commented Feb 21, 2023

Blocked by #2278

@LesnyRumcajs
Copy link
Member

Blocked by #2278

Doesn't seem to be directly related to ParityDb; I'd remove it as a blocker.

@LesnyRumcajs LesnyRumcajs self-assigned this Feb 21, 2023
@elmattic
Copy link
Contributor

Maybe we could remove (rocks_db member) in Config struct as well.

@LesnyRumcajs
Copy link
Member

We don't want to remove RocksDb, only deprecate it in a way. As far as I remember, it needs to be there for serialisation reasons. Or am I missing something?

@elmattic
Copy link
Contributor

elmattic commented Feb 21, 2023

Yeah, it's here if you have an old config file, with some RocksDb config section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants