Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for RUSTSEC-2020-0071 #2627

Closed
hanabi1224 opened this issue Mar 2, 2023 · 5 comments · Fixed by #3380
Closed

Tracking issue for RUSTSEC-2020-0071 #2627

hanabi1224 opened this issue Mar 2, 2023 · 5 comments · Fixed by #3380
Labels

Comments

@hanabi1224
Copy link
Contributor

Issue summary

I've made a fix to upstream boa_engine with boa-dev/boa#2627
We could resolve https://github.com/ChainSafe/forest/security/dependabot/20 and remove --ignore RUSTSEC-2020-0071 from here once boa_engine makes a new release.

Other information and links

@lemmih
Copy link
Contributor

lemmih commented Jul 8, 2023

boa_engine was fixed but RUSTSEC-2020-0071 is also triggered by chrono: chronotope/chrono#1073

@hanabi1224
Copy link
Contributor Author

boa_engine was fixed but RUSTSEC-2020-0071 is also triggered by chrono: chronotope/chrono#1073

@lemmih We have removed oldtime feature from chrono by doing below, the last time I checked it did not cause RUSTSEC-2020-0071

chrono = { version = "0.4", default-features = false, features = ["clock"] }

@aatifsyed
Copy link
Contributor

Boa engine is not fixed in 0.16:

$ git describe --tags 
v0.16
$ cargo audit -n
      Loaded 557 security advisories (from /home/aatif/.cargo/advisory-db)
    Scanning Cargo.lock for vulnerabilities (193 crate dependencies)
Crate:     time
Version:   0.1.44
...
Dependency tree:
time 0.1.44
└── chrono 0.4.22
    └── boa_engine 0.16.0
        ├── boa_wasm 0.16.0
        ├── boa_tester 0.16.0
        ├── boa_examples 0.16.0
        └── boa_cli 0.16.0
...

The right fix is to bump to 0.17, but it's non-trivial

@aatifsyed
Copy link
Contributor

chrono asserts that it doesn't call the vulnerable APIs, which is good enough to close this I think

chronotope/chrono#602 (comment)

@hanabi1224
Copy link
Contributor Author

@aatifsyed #3380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants