Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a disable GC option to config #2721

Closed
elmattic opened this issue Mar 28, 2023 · 2 comments · Fixed by #2723
Closed

Add a disable GC option to config #2721

elmattic opened this issue Mar 28, 2023 · 2 comments · Fixed by #2723
Assignees
Labels
Ready Issue is ready for work and anyone can freely assign it to themselves

Comments

@elmattic
Copy link
Contributor

Issue summary

In some cases like testing quickly a new feature or just doing some performance benchmark on mainnet, we would like to disable entirely GC in Forest.
Garbage Collection can add a significant overhead to the application, and you only really need it when running a production node.

Other information and links

https://github.com/ChainSafe/forest/blob/main/forest/shared/src/cli/config.rs#L176

@elmattic elmattic added the Ready Issue is ready for work and anyone can freely assign it to themselves label Mar 28, 2023
@hanabi1224 hanabi1224 self-assigned this Mar 28, 2023
@hanabi1224
Copy link
Contributor

@elmattic How about a command line option --no-gc?

@elmattic
Copy link
Contributor Author

👍 I'm fine with that. Actually I think it doesn't need to be in config file since it's something more for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Issue is ready for work and anyone can freely assign it to themselves
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants