Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive cli mpool commands #2728

Closed
elmattic opened this issue Mar 29, 2023 · 0 comments · Fixed by #3052
Closed

Revive cli mpool commands #2728

elmattic opened this issue Mar 29, 2023 · 0 comments · Fixed by #3052
Assignees
Labels
CLI Ready Issue is ready for work and anyone can freely assign it to themselves

Comments

@elmattic
Copy link
Contributor

elmattic commented Mar 29, 2023

Issue summary

Right now the cli mpool subcommands in Forest remain empty with some weird comment:

impl MpoolCommands {
    pub fn run(&self, _config: Config) -> anyhow::Result<()> {
        // match self {}
        Ok(())
    }
}

I believe we used to have some of them implemented (here's a related PR).
We need to revive what was implemented.

Ideally we should have most of what is exposing Lotus, but starting with mpool stat and mpool pending would be ok.

Other information and links

https://lotus.filecoin.io/lotus/manage/lotus-cli/#lotus-mpool

@elmattic elmattic added CLI Ready Issue is ready for work and anyone can freely assign it to themselves labels Mar 29, 2023
@elmattic elmattic added this to the Forest 🌲 Infrastructure milestone Mar 29, 2023
@elmattic elmattic self-assigned this Mar 29, 2023
@elmattic elmattic mentioned this issue Mar 31, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Ready Issue is ready for work and anyone can freely assign it to themselves
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant