Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove uncompressed from filops snapshots #2888

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented May 16, 2023

Summary of changes

Changes introduced in this pull request:

  • FILOps is no longer serving uncompressed snapshots and their latest is redirecting to a compressed one. Adapted Forest logic to this.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the remove-uncompressed-filops branch 2 times, most recently from 1407970 to 34db3e5 Compare May 16, 2023 10:08
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review May 16, 2023 10:12
Copy link
Contributor

@hanabi1224 hanabi1224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should toggle the flag, fetching compressed by default and use --uncompressed to fetch uncompressed. Or maybe drop the flag and let users decompress on their own

@lemmih lemmih merged commit 7548fd4 into main May 16, 2023
19 checks passed
@lemmih lemmih deleted the remove-uncompressed-filops branch May 16, 2023 10:49
@LesnyRumcajs
Copy link
Member Author

Maybe we should toggle the flag, fetching compressed by default and use --uncompressed to fetch uncompressed. Or maybe drop the flag and let users decompress on their own

there's already a tracking issue for this #2873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants