Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forest-cli sync wait exits too early #3540

Closed
1 task
lemmih opened this issue Oct 3, 2023 · 0 comments · Fixed by #3660
Closed
1 task

forest-cli sync wait exits too early #3540

lemmih opened this issue Oct 3, 2023 · 0 comments · Fixed by #3660
Assignees
Labels
Bug Priority: 3 - Medium Ready Issue is ready for work and anyone can freely assign it to themselves

Comments

@lemmih
Copy link
Contributor

lemmih commented Oct 3, 2023

Issue summary

The forest-cli sync wait RPC call doesn't wait until Forest has entered the follow mode. Instead, it merely waits for the completion of a single sync-range step. When syncing to a network, Forest will query the current HEAD and then initiate a sync-range from the heaviest tipset to the current HEAD. This step is then repeated until Forest has caught up. When we call forest-cli sync wait, we should wait until Forest has completely caught up rather than waiting for a single sync-range step.

Acceptance criteria:

  • forest-cli sync wait guarantees that Forest is in the follow mode.

Other information and links

@lemmih lemmih added Priority: 3 - Medium Bug Ready Issue is ready for work and anyone can freely assign it to themselves labels Oct 3, 2023
@sudo-shashank sudo-shashank self-assigned this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Priority: 3 - Medium Ready Issue is ready for work and anyone can freely assign it to themselves
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants