-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download actor bundles at runtime #3614
Comments
Instead of hosting the all-in-one bundle, I currently implemented downloading the bundles from GH (built-in-actors releases) and, alternatively, DO. The all-in-one file is not cached anywhere - it's in the DB and checked at startup that all manifests sit there. The downside of this approach is that at startup, the user has to download significantly more (the actor bundles are not compressed). Also, in a DB cleanup, they have to re-download it. |
It's not clear to me that |
Is there a way to eagerly cache the required bundles? If I'm trying to run |
|
Issue summary
Background
This PR #3276 moved runtime actor downloads to compile-time. At the moment, the actor bundle sits in the git lfs (#3360). With every new actors' bundle, we need to update it (append new bundles). Until the last upgrade, the bundle size was only ~2.3MB. The NV21 bundle (which is still missing a bundle for mainnet) is almost 8 MB.
Problem
crates.io has a hard limit of 10 MB enforced during
cargo publish
(at the push stage, so our dry-run wouldn't catch it). With the new bundles, we exceed this limitWe still want to push to crates.io.
Solution
Move downloading all-in-one bundle to runtime. Theoretically, we could do it at the build stage, but
cargo publish
wouldn't accept it. We should store the all-in-one bundle in:Use that endpoint to download the bundle at Forest startup.
Also, we have to publish unreleased
forest
versions (so far it's only0.14.0
).Acceptance criteria
crates.io
are released.Other information and links
The text was updated successfully, but these errors were encountered: