Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove filops snapshot provider and fix ci #3878

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

hanabi1224
Copy link
Contributor

Summary of changes

Filops snapshot service has been shut down, update the code and CI accordingly.

https://github.com/ChainSafe/forest/actions/runs/7551462787/job/20562704877?pr=3873#step:6:50

+ forest-tool snapshot fetch --chain calibnet --vendor filops
2024-01-17T08:24:58.902367Z ERROR forest_filecoin::cli_shared::cli: Failed fetching the snapshot: error sending request for url (https://snapshots.calibrationnet.filops.net/minimal/latest.zst): error trying to connect: dns error: failed to lookup address information: No address associated with hostname

Changes introduced in this pull request:

  • remove Filops from TrustedVendor
  • fix CI

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@@ -36,7 +36,6 @@ use crate::cli_shared::snapshot::parse::ParsedFilename;
pub enum TrustedVendor {
#[default]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeps TrustedVendor to allow new snapshot providers in the future

@hanabi1224 hanabi1224 marked this pull request as ready for review January 17, 2024 08:43
@hanabi1224 hanabi1224 requested a review from a team as a code owner January 17, 2024 08:43
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and sudo-shashank and removed request for a team January 17, 2024 08:43
@hanabi1224 hanabi1224 force-pushed the hm/remove-filops-snapshot-provider branch from afe534b to f6b6b9e Compare January 17, 2024 08:45
@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Jan 17, 2024

@hanabi1224 shall we delete this test now? Ideally, we'd have no mentions of FilOps anymore (except for the bootstrap nodes).

Or at least add a comment, so that future engineers don't have to do any archaeology to understand what this is about.

@hanabi1224
Copy link
Contributor Author

@hanabi1224 shall we delete this test now? Ideally, we'd have no mentions of FilOps anymore (except for the bootstrap nodes).

Or at least add a comment, so that future engineers don't have to do any archaeology to understand what this is about.

@LesnyRumcajs Removed. Please re-approve

@hanabi1224 hanabi1224 added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 598ea86 Jan 17, 2024
27 checks passed
@hanabi1224 hanabi1224 deleted the hm/remove-filops-snapshot-provider branch January 17, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants