Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): improve failure messages for Filecoin.EthEstimateGas #4554

Open
hanabi1224 opened this issue Jul 18, 2024 · 0 comments
Open

feat(rpc): improve failure messages for Filecoin.EthEstimateGas #4554

hanabi1224 opened this issue Jul 18, 2024 · 0 comments

Comments

@hanabi1224
Copy link
Contributor

Issue summary

Lotus uses some Filecoin.EthCall functionalities that have yet to be implemented in forest to make the failure messages more user-friendly for Filecoin.EthEstimateGas. We should close the gap once Filecoin.EthCall is implemented
e.g.

2024-07-17T14:53:44.6298673Z | Filecoin.EthEstimateGas                           | Rejected("Message has no gas limit set")                                                            | Rejected("failed to estimate gas: message execution failed: exit 33, revert reason: 0x5416eb985904247900000000000000000000000000000000000000000000000000000000, vm error: message failed with backtrace:\n00: f0131541 (method 3844450837) -- contract reverted (33)\n (RetCode=33)") |
2024-07-17T14:53:44.6304762Z | Filecoin.EthEstimateGas                           | Rejected("Message has no gas limit set")                                                            | Rejected("failed to estimate gas: message execution failed: exit 33, revert reason: none, vm error: message failed with backtrace:\n00: f0120962 (method 3844450837) -- contract reverted (33)\n (RetCode=33)")                                                                       |
2024-07-17T14:53:44.6310764Z | Filecoin.EthEstimateGas (3)                       | Rejected("Message has no gas limit set")                                                            | Rejected("failed to estimate gas: message execution failed: exit ErrUnhandledMessage(22), revert reason: none, vm error: message failed with backtrace:\n00: f017387 (method 3844450837) -- invalid method: 3844450837 (22)\n (RetCode=22)")                                          |

Other information and links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant