Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.1 is not compatible with other libp2ps #127

Closed
Menduist opened this issue Jan 10, 2022 · 5 comments
Closed

5.0.1 is not compatible with other libp2ps #127

Menduist opened this issue Jan 10, 2022 · 5 comments
Assignees

Comments

@Menduist
Copy link

Trying to connect to nim-libp2p or go-libp2p using js-libp2p-noise v5.0.1:

AggregateError:
    Error: Error occurred during XX handshake: xx handshake stage 1 validation fail
        at Noise.performXXHandshake (./js-libp2p/node_modules/@chainsafe/libp2p-noise/dist/src/noise.js:185:19)
        at processTicksAndRejections (node:internal/process/task_queues:96:5)
        at async Noise.performHandshake (./js-libp2p/node_modules/@chainsafe/libp2p-noise/dist/src/noise.js:154:20)
        at async Noise.secureOutbound (./js-libp2p/node_modules/@chainsafe/libp2p-noise/dist/src/noise.js:79:27)
        at async Upgrader._encryptOutbound (./js-libp2p/src/upgrader.js:406:12)
        at async Upgrader.upgradeOutbound (./js-libp2p/src/upgrader.js:176:11)
        at async ClassIsWrapper.dial (./js-libp2p/node_modules/libp2p-websockets/src/index.js:54:18)
        at async TransportManager.dial (./js-libp2p/src/transport-manager.js:111:14)
        at async ./js-libp2p/src/dialer/dial-request.js:78:18
        at async ./js-libp2p/node_modules/p-some/index.js:53:19
    at maybeSettle (./js-libp2p/node_modules/p-some/index.js:31:11)
    at ./js-libp2p/node_modules/p-some/index.js:69:23

Works fine with 5.0.0

@dapplion
Copy link
Contributor

CC @mpetrunic @wemeetagain

@wemeetagain
Copy link
Member

Very likely the problem was introduced in #118
We'll resolve #128 and cut a new release once we've identified and resolved the issue.

@wemeetagain
Copy link
Member

It looks like this problem was introduced in #125

I've got a branch that tests against go-libp2p showing the error: https://github.com/ChainSafe/js-libp2p-noise/tree/reproduce-127
The test needs polish, it not reliable and it doesn't properly shut down the go-libp2p daemon, but it proves the point. Testing against v5.0.0 shows success whereas testing against #125 shows the error.

@achingbrain any thoughts on what might have gone wrong?

@mpetrunic
Copy link
Member

Fixed in 5.0.2

@wemeetagain
Copy link
Member

resolved with #129 and v5.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants