feat!: yield uint8arraylists #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
feat/support-yielding-uint8arraylists
branch
from
1459675
to
8495ae3
Compare
|
N.b depends on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 95.60% 95.60% -0.01%
==========================================
Files 14 14
Lines 2207 2206 -1
Branches 329 329
==========================================
- Hits 2110 2109 -1
Misses 97 97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Nov 25, 2023
The general pattern of stream muxers is to yield protocol stream data framed by some additional metadata - stream id, flags, etc. The frame data can be prepended/appended to the protocol stream data by using a `Uint8ArrayList` instead of a `Uint8Array`, this removes the need to copy the protocol data into a new `Uint8Array` for every frame. The new `@libp2p/interface` version allows muxers to emit `Uint8ArrayList`s as well as `Uint8Array`s so we can send protocol stream data to a transport in a no-copy operation.
achingbrain
force-pushed
the
feat/support-yielding-uint8arraylists
branch
from
8495ae3
to
9a48fd3
Compare
wemeetagain
approved these changes
Nov 29, 2023
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general pattern of stream muxers is to yield protocol stream data framed by some additional metadata - stream id, flags, etc.
The frame data can be prepended/appended to the protocol stream data by using a
Uint8ArrayListinstead of aUint8Array, this removes the need to copy the protocol data into a newUint8Arrayfor every frame.The new
@libp2p/interfaceversion allows muxers to emitUint8ArrayLists as well asUint8Arrays so we can send protocol stream data to a transport in a no-copy operation.In particular yielding a single
Uint8ArrayListwith the frame header plus the data buffer gets us close to that target 200ms connection establishment time:BREAKING CHANGE: requires
js-libp2p@1.0.0