Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepareBeaconCommitteeSubnet performance bottleneck #2456

Closed
dapplion opened this issue May 1, 2021 · 1 comment · Fixed by #2427
Closed

prepareBeaconCommitteeSubnet performance bottleneck #2456

dapplion opened this issue May 1, 2021 · 1 comment · Fixed by #2427
Labels
prio-high Resolve issues as soon as possible. scope-performance Performance issue and ideas to improve performance.

Comments

@dapplion
Copy link
Contributor

dapplion commented May 1, 2021

Describe the bug

prepareBeaconCommitteeSubnet takes too much potentially breaking the validator's workflow. In average it takes about 12 seconds but this snapshot it takes 4s. The cost comes from computeSubnetForSlot()

Screenshot from 2021-05-01 16-03-28
Screenshot from 2021-05-01 16-05-46

Expected behavior

prepareBeaconCommitteeSubnet should almost be free since that information should already be cached in the epoch context.
@dapplion dapplion added scope-performance Performance issue and ideas to improve performance. prio-high Resolve issues as soon as possible. labels May 1, 2021
@dapplion dapplion mentioned this issue May 2, 2021
Merged
@dapplion
Copy link
Contributor Author

dapplion commented May 3, 2021

After merging #2427 metrics show that it takes ~30ms to process prepareBeaconCommitteeSubnet requests, down from 10-20 seconds 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-high Resolve issues as soon as possible. scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attestation Service ChainSafe/lodestar
1 participant
@dapplion