Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDomain uses wrong epochMsg #2615

Closed
dapplion opened this issue Jun 2, 2021 · 0 comments · Fixed by #2616
Closed

getDomain uses wrong epochMsg #2615

dapplion opened this issue Jun 2, 2021 · 0 comments · Fixed by #2616
Labels
prio-high Resolve issues as soon as possible.

Comments

@dapplion
Copy link
Contributor

dapplion commented Jun 2, 2021

Describe the bug

Through fork transitions and using the bls batch verify getDomain will pick the wrong epoch.

Expected behavior

We should never guess the epoch message from the state but pass it explicitly from the object we are verifying against
@dapplion dapplion added the prio-high Resolve issues as soon as possible. label Jun 2, 2021
@dapplion dapplion mentioned this issue Jun 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-high Resolve issues as soon as possible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly pass epoch message sig to getDomain ChainSafe/lodestar
1 participant
@dapplion