Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why there are so few mesh peers per attestation subnet #3555

Closed
twoeths opened this issue Dec 28, 2021 · 6 comments
Closed

Investigate why there are so few mesh peers per attestation subnet #3555

twoeths opened this issue Dec 28, 2021 · 6 comments
Assignees
Labels
prio-high Resolve issues as soon as possible. scope-profitability Issues to directly improve validator performance and its profitability.

Comments

@twoeths
Copy link
Contributor

twoeths commented Dec 28, 2021

Describe the bug

This happens in both prater and mainnet: we have a lot of topic peers

Screen Shot 2021-12-28 at 10 48 00

but so few mesh peers
Screen Shot 2021-12-28 at 10 49 48

Expected behavior

  • Given options.D = 8, we should have up to 8 mesh peers per subnet
  • Track both mesh peers (already exist) and topic peers in the grafana dashboard
@twoeths
Copy link
Contributor Author

twoeths commented Dec 28, 2021

when joining a topic, mesh is created with peers that have score >=0, so we should add gossip peer score metric.

@twoeths
Copy link
Contributor Author

twoeths commented Jan 28, 2022

It shows that at some points we have so few peers at mesh score threshold (score >=0)

Screen Shot 2022-01-28 at 14 51 38

@wemeetagain what's the consequence of having so few mesh peers?

@twoeths
Copy link
Contributor Author

twoeths commented Jan 28, 2022

Adrian at lighthouse mentioned that Most are positive and hit the max of 100. Rarely see negative scores at lighthouse, we need to investigate why peer score is so low in lodestar

@dapplion dapplion added the prio-high Resolve issues as soon as possible. label Feb 4, 2022
@philknows philknows added the scope-networking All issues related to networking, gossip, and libp2p. label Feb 4, 2022
@twoeths
Copy link
Contributor Author

twoeths commented Feb 7, 2022

this could mitigate the issue #3705, should assess the situation after that's done

@twoeths
Copy link
Contributor Author

twoeths commented Feb 24, 2022

#3781 helps us gain good gossip peer score, hence more mesh peers. This could help us mitigate the issue.

Also, we need to care about Job Wait Time. If it's >3s, peers potentially get penalized due to broken IWANT/IHAVE promises, this is from a node of 30 validators

Screen Shot 2022-02-24 at 09 28 57

@dapplion dapplion added scope-profitability Issues to directly improve validator performance and its profitability. and removed scope-networking All issues related to networking, gossip, and libp2p. labels May 10, 2022
@twoeths
Copy link
Contributor Author

twoeths commented May 12, 2022

There are good number of mesh peers in mainnet nodes - v0.36.0

Screen Shot 2022-05-12 at 14 52 51

closing the issue

@twoeths twoeths closed this as completed May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-high Resolve issues as soon as possible. scope-profitability Issues to directly improve validator performance and its profitability.
Projects
None yet
Development

No branches or pull requests

3 participants