Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit peer discovery related configurations #3673

Closed
dadepo opened this issue Jan 27, 2022 · 2 comments
Closed

Revisit peer discovery related configurations #3673

dadepo opened this issue Jan 27, 2022 · 2 comments
Assignees
Labels
meta-technical-debt Issues introducing or resolving technical debts. prio-low This is nice to have. scope-networking All issues related to networking, gossip, and libp2p.

Comments

@dadepo
Copy link
Contributor

dadepo commented Jan 27, 2022

Is your feature request related to a problem? Please describe.

While working on issue #3568, I noticed a couple of things not consistent or confusing regarding how some peer discovery settings are configured and used.

For example:

  • We configure the libp2p node to use Bootstap and MDN as peer discovery mechanism but we essential switch it off by setting both peerDiscovery.autodial and connectionManager.autodial to off. Is it not better (less confusing) to remove the peer discovery configurations, if it is not going to be used and handle discovery and peer dialling in code as we are doing in the discover.ts?
  • It seems network.discv5.enabled is not being used in the code (at least I could not find where it is being used) Confirm if it is used. If not, should it be used to determine if to connect to peers based on network.discv5.bootEnrs? or it has another purpose?
  • What is the difference between network.bootMultiaddrs and network.discv5.bootEnrs. Is network.bootMultiaddrs now redundant? and can it be removed?

Describe the solution you'd like

Look into the questions raised above, and work on any follow up tasks if required (code changes, update to documentation etc)

@dadepo dadepo self-assigned this Jan 27, 2022
@dapplion dapplion changed the title Revisit Peer Discovery Related Configurations Revisit peer discovery related configurations Feb 4, 2022
@dapplion
Copy link
Contributor

dapplion commented Feb 4, 2022

Good points! I think all the inconsistencies come from consecutive updates which never fully cleaned up the options. Feel free to propose a new set of options that are tidy and make sense, it's confusing even to me.

  • network.bootMultiaddrs: initial libp2p connections.
  • network.discv5.bootEnrs: initial discv5 connections.

@dapplion dapplion added meta-technical-debt Issues introducing or resolving technical debts. prio-low This is nice to have. scope-networking All issues related to networking, gossip, and libp2p. labels May 10, 2022
@dapplion
Copy link
Contributor

dapplion commented Feb 14, 2023

Not applicable after 2022 refactors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-technical-debt Issues introducing or resolving technical debts. prio-low This is nice to have. scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Development

No branches or pull requests

2 participants