Revisit peer discovery related configurations #3673
Labels
meta-technical-debt
Issues introducing or resolving technical debts.
prio-low
This is nice to have.
scope-networking
All issues related to networking, gossip, and libp2p.
Is your feature request related to a problem? Please describe.
While working on issue #3568, I noticed a couple of things not consistent or confusing regarding how some peer discovery settings are configured and used.
For example:
peerDiscovery.autodial
andconnectionManager.autodial
to off. Is it not better (less confusing) to remove the peer discovery configurations, if it is not going to be used and handle discovery and peer dialling in code as we are doing in thediscover.ts
?network.discv5.enabled
is not being used in the code (at least I could not find where it is being used) Confirm if it is used. If not, should it be used to determine if to connect to peers based onnetwork.discv5.bootEnrs
? or it has another purpose?network.bootMultiaddrs
andnetwork.discv5.bootEnrs
. Isnetwork.bootMultiaddrs
now redundant? and can it be removed?Describe the solution you'd like
Look into the questions raised above, and work on any follow up tasks if required (code changes, update to documentation etc)
The text was updated successfully, but these errors were encountered: