Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The nightly release is breaking because lodestar-cli release on npm doesn't bundle the latest dev lodestar- packages #3676

Closed
g11tech opened this issue Jan 28, 2022 · 1 comment · Fixed by #3679

Comments

@g11tech
Copy link
Contributor

g11tech commented Jan 28, 2022

It seems that even though the lerna publish --canary release is releasing all packages under dev versions for e.e dev.2+0fea7126d8, with the correct linked dependencies, for e.g. of installed lodestar-cli ( npm install @chainsafe/lodestar-cli@0.34.0-dev.2+0fea7126d8):

"node_modules/@chainsafe/lodestar-cli": {                                                                                            
      "version": "0.34.0-dev.2",                                                                                                         
      "resolved": "https://registry.npmjs.org/@chainsafe/lodestar-cli/-/lodestar-cli-0.34.0-dev.2.tgz",                                  
      "integrity": "sha512-OLkmeqHU6YpY7eMqF28/8HzE4mtX8S4MCNjt+5SnTGAndqbUJmmRHeLCVapSjFAX0AVgVfli+kcwUVcQr4PVkQ==",                    
      "dependencies": {                                                                                                                  
        "@chainsafe/abort-controller": "^3.0.1",                                                                                         
        "@chainsafe/bls": "6.0.3",                                                                                                       
        "@chainsafe/bls-keygen": "^0.3.0",                                                                                               
        "@chainsafe/bls-keystore": "2.0.0",                                                                                              
        "@chainsafe/blst": "^0.2.2",                                                                                                     
        "@chainsafe/discv5": "^0.6.7",                                                                                                   
        "@chainsafe/lodestar": "^0.34.0-dev.2+0fea7126d8",                                                                               
        "@chainsafe/lodestar-api": "^0.34.0-dev.2+0fea7126d8",                                                                           
        "@chainsafe/lodestar-beacon-state-transition": "^0.34.0-dev.2+0fea7126d8",                                                       
        "@chainsafe/lodestar-config": "^0.34.0-dev.2+0fea7126d8",                                                                        
        "@chainsafe/lodestar-db": "^0.34.0-dev.2+0fea7126d8",                                                                            
        "@chainsafe/lodestar-params": "^0.34.0-dev.2+0fea7126d8",                                                                        

But npm install is resolving/installing the other lodestar-* monorepo packages of 0.34.0 version:
(from generated package-lock.json)

    "node_modules/@chainsafe/lodestar-config": {                                                                    
      "version": "0.34.0",
      "resolved": "https://registry.npmjs.org/@chainsafe/lodestar-config/-/lodestar-config-0.34.0.tgz",
      "integrity": "sha512-HE47J0R/77u17vzg3shk+s111cLK50H+G1FitMD0POLF+3Ba9/Scdy7egIfTJKU/z+xHFJ8iBMjtOGPdS+QuZw==",
      "dependencies": {                                                                                 
        "@chainsafe/lodestar-params": "^0.34.0",                                                                     
        "@chainsafe/lodestar-types": "^0.34.0",
        "@chainsafe/ssz": "^0.8.20"  
      } 
    },            

This is breaking nightly release where there are breaking changes between cli and config but more importantly, the old minor release code is being bundled with the latest dev cli which is supposed to refer the latest code of other packages.

Steps to repro:
do npm install @chainsafe/lodestar-cli@0.34.0-dev.2+0fea7126d8
and inspect the package-lock.json

Expected:
The resolved versions of the other lodestar- monorepo packages should exactly match the resolved cli version

@g11tech
Copy link
Contributor Author

g11tech commented Jan 28, 2022

cc @philknows @dapplion @wemeetagain @tuyennhv @dadepo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant