Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gossip Block Processed delay increased in v0.34.0 #3732

Closed
twoeths opened this issue Feb 8, 2022 · 4 comments
Closed

Gossip Block Processed delay increased in v0.34.0 #3732

twoeths opened this issue Feb 8, 2022 · 4 comments
Assignees
Labels
prio-high Resolve issues as soon as possible. scope-performance Performance issue and ideas to improve performance.
Milestone

Comments

@twoeths
Copy link
Contributor

twoeths commented Feb 8, 2022

Describe the bug

Right now with v0.34.0 in hetzner-test1
Screen Shot 2022-02-08 at 14 46 17

Expected behavior

This is from v0.33.0
Screen Shot 2022-02-08 at 14 48 11

@twoeths
Copy link
Contributor Author

twoeths commented Feb 8, 2022

one issue is BackfillSync query BlockArchive db a lot which takes 18% of cpu time
Screen Shot 2022-02-08 at 15 05 15

Backfill Sync also uses 3% of cpu time for blockToHeader() util
Screen Shot 2022-02-08 at 15 07 31

0207_hetzner_test1_backfill_sync.cpuprofile.zip

@twoeths
Copy link
Contributor Author

twoeths commented Feb 9, 2022

the other issue is array.shift() in JobItem.push(), which takes 17% cpu time in another profile

Screen Shot 2022-02-09 at 13 51 38

Screen Shot 2022-02-09 at 14 26 15

[0209_hetzner_test1_processRpc.cpuprofile.zip]
(https://github.com/ChainSafe/lodestar/files/8030365/0209_hetzner_test1_processRpc.cpuprofile.zip)

@dapplion could we use a linked list in JobItemQueue?

@twoeths
Copy link
Contributor Author

twoeths commented Feb 10, 2022

part of the issue is there are a lot of late gossip blocks recently in prater, even when I try with v0.33.0

mainnet gossip block processed delay is more stable in general, however our metric shows that it doubles the value I saw in the past, this is due to our node performance

@twoeths
Copy link
Contributor Author

twoeths commented Feb 17, 2022

as with latest master, the metric is good so closing the issue

[contabo-17 - 30 validators]
Screen Shot 2022-02-17 at 14 52 51

@twoeths twoeths closed this as completed Feb 17, 2022
@dapplion dapplion added this to the v0.35.0 milestone Feb 18, 2022
@dapplion dapplion added scope-performance Performance issue and ideas to improve performance. prio-high Resolve issues as soon as possible. labels Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-high Resolve issues as soon as possible. scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Development

No branches or pull requests

2 participants