Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to validate attestation: Requesting slot committee out of range #4396

Closed
twoeths opened this issue Aug 11, 2022 · 3 comments · Fixed by #4589
Closed

Not able to validate attestation: Requesting slot committee out of range #4396

twoeths opened this issue Aug 11, 2022 · 3 comments · Fixed by #4589
Assignees
Labels
prio-medium Resolve this some time soon (tm). scope-logging Issue about logs: hygiene, format issues, improvements.

Comments

@twoeths
Copy link
Contributor

twoeths commented Aug 11, 2022

Describe the bug

Around the prater/goerli merge, we got

Aug-11 02:29:30.011[]                 info: Synced - slot: 3639747 - head: 3639747 0xaace…1edd - execution: valid(0x62bd…24b8) - finalized: 0x9469…c31e:113739 - peers: 50
Aug-11 02:29:41.278[NETWORK]         error: Gossip validation beacon_attestation threw a non-GossipActionError  Requesting slot committee out of range epoch: 113742 current: 113740
Error: Requesting slot committee out of range epoch: 113742 current: 113740
    at EpochContext.getShufflingAtEpoch (file:///usr/app/node_modules/@lodestar/state-transition/src/cache/epochContext.ts:720:13)
    at EpochContext.getShufflingAtSlot (file:///usr/app/node_modules/@lodestar/state-transition/src/cache/epochContext.ts:709:17)
    at getCommitteeIndices (file:///usr/app/node_modules/@lodestar/beacon-node/src/chain/validation/attestation.ts:287:56)
    at validateGossipAttestation (file:///usr/app/node_modules/@lodestar/beacon-node/src/chain/validation/attestation.ts:91:28)
    at runMicrotasks (<anonymous>)
    at runNextTicks (node:internal/process/task_queues:61:5)
    at listOnTimeout (node:internal/timers:528:9)
    at processTimers (node:internal/timers:502:7)
    at validateGossipAttestationRetryUnknownRoot (file:///usr/app/node_modules/@lodestar/beacon-node/src/network/gossip/handlers/index.ts:349:14)
    at beacon_attestation (file:///usr/app/node_modules/@lodestar/beacon-node/src/network/gossip/handlers/index.ts:182:28)

note that the sync status stated the head 3639747 at epoch 113742, not sure why the head epoch of 113740 was used to validate attestation

Expected behavior

No error

@twoeths
Copy link
Contributor Author

twoeths commented Aug 11, 2022

the attestation was from some out-of-synced node which voted for some old block, lodestar used the state at that block and was not able to get committee.

In this case, since that node is out-of-synced, that attestation is not valid since validator is already not part of committee, so the error is expected. Maybe we should find a better way to log the error.

@philknows
Copy link
Member

Agreed that this can be a scary looking error. Errors generally mean that the user themselves incorrectly did something and need to take action to fix it. This is not something that the user itself can fix. Would either:

  • Add additional information to explain why this happens or
  • Downgrade this to some sort of info or warning that provides this notice, but not a scary looking error.

@philknows philknows added the scope-ux Issues for CLI UX or general consumer UX. label Aug 11, 2022
@dapplion dapplion added prio-medium Resolve this some time soon (tm). scope-logging Issue about logs: hygiene, format issues, improvements. and removed scope-ux Issues for CLI UX or general consumer UX. labels Aug 13, 2022
@twoeths
Copy link
Contributor Author

twoeths commented Sep 23, 2022

got same issue around the time of merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm). scope-logging Issue about logs: hygiene, format issues, improvements.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants