Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capella (withdrawals) hardfork integration tracker #4571

Closed
25 tasks done
g11tech opened this issue Sep 20, 2022 · 1 comment
Closed
25 tasks done

Capella (withdrawals) hardfork integration tracker #4571

g11tech opened this issue Sep 20, 2022 · 1 comment
Assignees
Labels
Epic Issues used as milestones and tracking multiple issues. spec-capella 🦉 Issues targeting the Capella spec version

Comments

@g11tech
Copy link
Contributor

g11tech commented Sep 20, 2022

Tracker to integrated capella hardfork in lodestar

Pending tasks:

  • test utils
    • Check capella handling in msgIdFn fn in gossip/encoding.ts
    • Add testcases for hardfork transition in network/fork.test.ts
  • handle getInteropState 's latestPayloadHeader assignment fork appropriate
  • Specs handle payload header type/assignment fork appropriate in
    • in initializeBeaconStateFromEth1 of test/spec/presets/genesis.ts
    • enable in spec
  • Spec tests
    • add runners for ["full_withdrawals", "partial_withdrawals", "bls_to_execution_change", "withdrawals"]
    • capella/random/random/pyspec_tests/randomized_11, capella/sanity/blocks/pyspec_tests, full_withdrawal_in_epoch_transition" (These tests specifically seem to have a full validator withdrawal with a validatorstill in sync committee. Remove once spec tests are fixed )
  • Implement Builder changes for capella (whenever they are available)

Major pending line items:

  • Handle gossips for blschange
  • implement the optimized withdrawal processing as and when PR is ready
  • Move to the new spec verison with queue current spec tests for capella has been disabled
    • remove MAX_PARTIAL_WITHDRAWALS_PER_EPOCH, WITHDRAWAL_QUEUE_LIMIT
    • change MAX_WITHDRAWALS_PER_PAYLOAD to 4 as per new without queue spec
  • add assetions in the withdrawal interop
@g11tech g11tech self-assigned this Sep 20, 2022
@philknows philknows added Epic Issues used as milestones and tracking multiple issues. spec-capella 🦉 Issues targeting the Capella spec version labels Oct 4, 2022
@philknows philknows pinned this issue Oct 4, 2022
@g11tech g11tech changed the title Capella hardfork integration tracker Capella hardfork integration tracker Nov 3, 2022
@g11tech g11tech changed the title Capella hardfork integration tracker Capella (withdrawals) hardfork integration tracker Nov 3, 2022
@g11tech
Copy link
Contributor Author

g11tech commented Jan 9, 2023

closing the tracker as the tasks look done 🎉

@g11tech g11tech closed this as completed Jan 9, 2023
@g11tech g11tech unpinned this issue Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Issues used as milestones and tracking multiple issues. spec-capella 🦉 Issues targeting the Capella spec version
Projects
None yet
Development

No branches or pull requests

2 participants