We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need track of unused expressions to clean up the code and avoid potential bugs.
For example this was missed due to missing lint rule. The assertion error has never been added to the list of errors.
lodestar/packages/cli/test/utils/simulation/assertions/defaults/missedBlocksAssertion.ts
Lines 36 to 42 in c780a1d
"no-unused-expressions": "error"
Could also consider adding other linters/scanners to CI such as SonarQube.
As discussed in discord
The text was updated successfully, but these errors were encountered:
Sorry, something went wrong.
nflaig
Successfully merging a pull request may close this issue.
Need track of unused expressions to clean up the code and avoid potential bugs.
For example this was missed due to missing lint rule. The assertion error has never been added to the list of errors.
lodestar/packages/cli/test/utils/simulation/assertions/defaults/missedBlocksAssertion.ts
Lines 36 to 42 in c780a1d
"no-unused-expressions": "error"
(no-unused-expressions, @typescript-eslint/no-unused-expressions)Could also consider adding other linters/scanners to CI such as SonarQube.
As discussed in discord
The text was updated successfully, but these errors were encountered: