Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint and fix unused expressions #5505

Closed
2 tasks done
nflaig opened this issue May 17, 2023 · 1 comment · Fixed by #6445
Closed
2 tasks done

Lint and fix unused expressions #5505

nflaig opened this issue May 17, 2023 · 1 comment · Fixed by #6445
Assignees
Labels
prio-low This is nice to have. scope-devex Issues for improving developer experience.

Comments

@nflaig
Copy link
Member

nflaig commented May 17, 2023

Need track of unused expressions to clean up the code and avoid potential bugs.

For example this was missed due to missing lint rule. The assertion error has never been added to the list of errors.

if (missedBlocksOnNode !== missedBlocksOnFirstNode) {
`node has different missed blocks than node 0. ${JSON.stringify({
id: nodes[i].cl.id,
missedBlocksOnNode,
missedBlocksOnFirstNode,
})}`;
}

Could also consider adding other linters/scanners to CI such as SonarQube.

As discussed in discord

@philknows
Copy link
Member

@philknows philknows added the prio-low This is nice to have. label Nov 7, 2023
@philknows philknows added the scope-devex Issues for improving developer experience. label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-low This is nice to have. scope-devex Issues for improving developer experience.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants