Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downscore clients with SSZ_SNAPPY_ERROR_OVER_SSZ_MAX_SIZE error #6315

Closed
twoeths opened this issue Jan 17, 2024 · 3 comments · Fixed by #6366
Closed

Downscore clients with SSZ_SNAPPY_ERROR_OVER_SSZ_MAX_SIZE error #6315

twoeths opened this issue Jan 17, 2024 · 3 comments · Fixed by #6366
Assignees
Labels
meta-bug Issues that identify a bug and require a fix. scope-networking All issues related to networking, gossip, and libp2p.

Comments

@twoeths
Copy link
Contributor

twoeths commented Jan 17, 2024

Describe the bug

Got a lot of errors like this

Jan-17 07:38:21.909[network]       verbose: Req  error method=metadata, version=2, encoding=ssz_snappy, client=Unknown, peer=16...pWVhz9, requestId=403654, code=SSZ_SNAPPY_ERROR_OVER_SSZ_MAX_SIZE, maxSize=17, sszDataLength=24
Error: SSZ_SNAPPY_ERROR_OVER_SSZ_MAX_SIZE

that only happens to "Unknown" client, I don't see we downscore them a lot, maybe we need to apply more penalties on them. If it happens a lot it may be disconnected by our peer manager heart beat
Screenshot 2024-01-17 at 16 15 57

Expected behavior

I think this error is similar to "REQUEST_ERROR_INVALID_RESPONSE_SSZ", need to apply low tolerance there, i.e. ~5 occurrences will get the peer banned

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

v1.14.0

@twoeths twoeths added the meta-bug Issues that identify a bug and require a fix. label Jan 17, 2024
@nflaig
Copy link
Member

nflaig commented Jan 17, 2024

There is another, possibly related error I am seeing on my Lodestar node (v1.14.0-rc.1)

Jan-17 09:17:23.039[network]         error: Error setting agentVersion for the peer peerId=16Uiu2HAmKpgbkNA2AKYvt4qfdwFsSwuM7NwE8aMMHoMJiCBAxKAL - NotFound: 
Error: NotFound: 

@philknows philknows added the scope-networking All issues related to networking, gossip, and libp2p. label Jan 19, 2024
@matthewkeil
Copy link
Member

There is another, possibly related error I am seeing on my Lodestar node (v1.14.0-rc.1)

Jan-17 09:17:23.039[network]         error: Error setting agentVersion for the peer peerId=16Uiu2HAmKpgbkNA2AKYvt4qfdwFsSwuM7NwE8aMMHoMJiCBAxKAL - NotFound: 
Error: NotFound: 

Talking with @tuyennhv this is a separate error. I created issue #6365

@matthewkeil
Copy link
Member

Fixed with #6366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix. scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants