Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow disabling builder if builder selection is set to builder only #6338

Open
nazarhussain opened this issue Jan 22, 2024 · 0 comments

Comments

@nazarhussain
Copy link
Contributor

nazarhussain commented Jan 22, 2024

We need to make sure if a proposerSettingsFile or keymanager have settings for a public key to BuilderOnly builder selection, then we should not allow user to disable the builder for that validator.

// At any point either the builder or execution or both flows should be active.
//
// Ideally such a scenario should be prevented on startup, but proposerSettingsFile or keymanager
// configurations could cause a validator pubkey to have builder disabled with builder selection builder only
// (TODO: independently make sure such an options update is not successful for a validator pubkey)
//
// So if builder is disabled ignore builder selection of builderonly if caused by user mistake

worth making an issue to follow up

Originally posted by @wemeetagain in #6241 (comment)

@nazarhussain nazarhussain changed the title > // (TODO: independently make sure such an options update is not successful for a validator pubkey) Do not allow disabling builder if builder selection is set to builder only Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant