-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metamask-deprecated .on({data, close}) used in constructor #3699
Comments
Just to provide our perspective, from the point of view of MetaMask and current provider standards, |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
I don't think this should be marked as stale. |
Are we gonna try to be backward compatible with old providers with the close event? If not we'll need to mark this as a breaking change and als change the according unit tests and mock providers. |
@wbt Could you please provide a complete example of a small webpage which results in those warnings with the newest 1.3.0 web3.min.js? |
@koraykoska Unfortunately I won't be able to do that in the next week or so. |
Substantive details are described here, but this Issue is filed in web3 for updates which may need to be made in web3 for no longer relying on deprecated
data
andclose
events if they are, in fact, actually deprecated.The text was updated successfully, but these errors were encountered: