Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask-deprecated .on({data, close}) used in constructor #3699

Closed
wbt opened this issue Aug 24, 2020 · 7 comments · Fixed by #3773
Closed

Metamask-deprecated .on({data, close}) used in constructor #3699

wbt opened this issue Aug 24, 2020 · 7 comments · Fixed by #3773
Assignees

Comments

@wbt
Copy link
Contributor

wbt commented Aug 24, 2020

Substantive details are described here, but this Issue is filed in web3 for updates which may need to be made in web3 for no longer relying on deprecated data and close events if they are, in fact, actually deprecated.

@rekmarks
Copy link

Just to provide our perspective, from the point of view of MetaMask and current provider standards, data and close are deprecated.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Oct 26, 2020
@wbt
Copy link
Contributor Author

wbt commented Oct 26, 2020

I don't think this should be marked as stale.

@GregTheGreek GregTheGreek removed the Stale Has not received enough activity label Oct 26, 2020
@Polycarpik
Copy link

@koraykoska

@koraykoska koraykoska self-assigned this Oct 27, 2020
@koraykoska
Copy link

Are we gonna try to be backward compatible with old providers with the close event? If not we'll need to mark this as a breaking change and als change the according unit tests and mock providers.

@koraykoska
Copy link

@wbt Could you please provide a complete example of a small webpage which results in those warnings with the newest 1.3.0 web3.min.js?

@wbt
Copy link
Contributor Author

wbt commented Oct 31, 2020

@koraykoska Unfortunately I won't be able to do that in the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants