Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document defaultBlock in methods.myMethod.call #3558

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Conversation

Velenir
Copy link
Contributor

@Velenir Velenir commented Jun 2, 2020

Description

methods.myMethod.call documentation doesn't mention defaultBlock parameter, but it works as expected.

I mostly copied description from eth.call

Type of change

Documentation change

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.
  • The browser visual inspection check looks ok: sudden-playground.surge.sh

@coveralls
Copy link

coveralls commented Jun 2, 2020

Coverage Status

Coverage remained the same at 89.738% when pulling 2943f6b on Velenir:patch-1 into e1ba5d5 on ethereum:1.x.

@Velenir Velenir mentioned this pull request Jun 2, 2020
8 tasks
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great! Thanks so much.

docs/web3-eth-contract.rst Outdated Show resolved Hide resolved
@cgewecke cgewecke added this to Done in v1.2.9 Jun 2, 2020
@cgewecke cgewecke moved this from Done to In Review in v1.2.9 Jun 2, 2020
@cgewecke cgewecke merged commit 3107c98 into web3:1.x Jun 2, 2020
@cgewecke cgewecke moved this from In Review to Done in v1.2.9 Jun 2, 2020
@ryanio ryanio mentioned this pull request Jun 2, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v1.2.9
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants