New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.x: Fix EIP-1193 provider subscriptions #3864
Conversation
Pull Request Test Coverage Report for Build 496709829
💛 - Coveralls |
Cool thanks for this will take a look at this! |
FYI: I'm receiving reports that using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installed this patch locally and tested using Firefox and MetaMask v9.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
purely from a code stand point this looks good!
1.x: Fix EIP-1193 provider subscriptions
1.x: Fix EIP-1193 provider subscriptions
This v1.3.2 version is a hot fix to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
This v1.3.2 version is a hot fix to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
This v1.3.3 version is a hot fix to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
This v1.3.3 version is a hot fix to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
…bscription Bump web3 dependency to v1.3.3 This v1.3.3 version is a hot fix to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
This v1.3.3 version is a hot fix to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
Bump web3 dependencies to the latest version v1.3.5 to address breaking changes in the MetaMask API provided in v.9. Details: web3/web3.js#3864 MetaMask/metamask-extension#8077 (comment)
Fixes #3651
Implements subscription support per EIP-1193.
Should be tested manually by maintainers with current MetaMask (^9.0.0) on Firefox.