Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unsubscribe and add a test (#4058) #4300

Merged
merged 9 commits into from Oct 5, 2021
Merged

Fix unsubscribe and add a test (#4058) #4300

merged 9 commits into from Oct 5, 2021

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Sep 8, 2021 •
edited

Took over #4058 to update CHANGELOG.md

@samlior @spacesailor24
Fix unsubscribe and add a test (#4058)
37d3f7a 
Co-authored-by: Alex <alex@chainsafe.io>
Co-authored-by: Wyatt Barnes <wyatt@writerof.software>
@spacesailor24 spacesailor24 added the 1.x 1.0 related issues label Sep 8, 2021
@render
Copy link

render bot commented Sep 8, 2021

Your Render PR Server URL is https://web3-js-pr-4300.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c4s35141nok4ouignin0.

@coveralls
Copy link

coveralls commented Sep 8, 2021 •
edited

Pull Request Test Coverage Report for Build 1308959319

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 427 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.3%) to 72.545%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/src/formatters.js 23 81.4%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 92 12.86%
packages/web3-eth-accounts/src/index.js 163 23.77%
Totals Coverage Status
Change from base Build 1308958204: -2.3%
Covered Lines: 3355
Relevant Lines: 4367
💛 - Coveralls

@spacesailor24 spacesailor24 marked this pull request as ready for review September 8, 2021 04:13
jdevcs
jdevcs previously approved these changes Sep 8, 2021
View reviewed changes
nazarhussain
nazarhussain previously approved these changes Sep 16, 2021
View reviewed changes
luu-alex
luu-alex previously approved these changes Sep 16, 2021
View reviewed changes
jdevcs
jdevcs previously approved these changes Sep 23, 2021
View reviewed changes
jdevcs
jdevcs previously approved these changes Sep 29, 2021
View reviewed changes
@spacesailor24 spacesailor24 merged commit dbb4350 into 1.x Oct 5, 2021
@spacesailor24 spacesailor24 deleted the wyatt/4058-unsubscribe-fix branch October 5, 2021 19:21
@spacesailor24 spacesailor24 mentioned this pull request Oct 9, 2021
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request May 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 28, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarhussain nazarhussain nazarhussain approved these changes

@jdevcs jdevcs jdevcs approved these changes

@luu-alex luu-alex luu-alex left review comments

Assignees

@spacesailor24 spacesailor24

Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spacesailor24 @coveralls @nazarhussain @luu-alex @jdevcs @samlior