Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proper Logging #21

Closed
dhruv-1001 opened this issue Jan 15, 2024 · 17 comments · Fixed by #69
Closed

Add Proper Logging #21

dhruv-1001 opened this issue Jan 15, 2024 · 17 comments · Fixed by #69
Assignees

Comments

@dhruv-1001
Copy link
Collaborator

dhruv-1001 commented Jan 15, 2024

Description

This issue tracks the implementation of a Proper Logging in our application.

Implementation Details

1. Define the API

  • Task: Design Logger class.
  • Details: Design a Logger class which have 4 levels of logging [debug, info, warn, error]. Omit logging for debug & info in case of production build.
  • Approval: The class design needs to be reviewed and approved before proceeding with implementation.

2. Implement Logger Class Logic

  • Task: Adding logger to required places.
  • Details: Add proper logging throughout the application, where there is need for logging both in deployment & production mode.
  • Dependence: This step is contingent upon the approval of the API design.

Resources

  • winston package can be used for logging.

Expected Outcomes

  • Useful logs throughout the application
  • Logger should work in 2 modes development & production [value to be picked up from .env]

Product Name

GeoIP

Project Name

GeoIP

Organization Name

SamagraX

Domain

NA

Tech Skills Needed

Node JS

Category

Feature

Mentor(s)

@ChakshuGautam

Complexity

Low

Copy link

c4gt-community-support bot commented Jan 15, 2024

Hi!
Important Details - These following details are helpful for contributors to effectively identify and contribute to tickets.

  • Sub-Category - Please mention the sub-category if any for the ticket

Please update the ticket

@Sweetdevil144
Copy link
Contributor

Hey @dhruv-1001 , are we sure that the docs are up to date? I think the server's shifted from using node.js to bun.js as I can see from the server. Is there a need to Update the docs along with this issue? If so, I'm up for the grab !!
(:

@dhruv-1001
Copy link
Collaborator Author

Hey @Sweetdevil144, i've raised a PR to update docs on this. You can continue with this issue though!

@Sweetdevil144
Copy link
Contributor

Sure @dhruv-1001 , Also, I think that not adding package-lock.json to .gitignore may cause problems for other's systems

@ALOK9442
Copy link

@dhruv-1001 sir is this issue open or someone is working? It'd be great if you can assign it to me.

@Sweetdevil144
Copy link
Contributor

@dhruv-1001 sir is this issue open or someone is working? It'd be great if you can assign it to me.

It's almost done by me. I've been a bit busy the past few days due to some reasons but I would do a PR by today.

@ALOK9442
Copy link

@dhruv-1001 sir is this issue open or someone is working? It'd be great if you can assign it to me.

It's almost done by me. I've been a bit busy the past few days due to some reasons but I would do a PR by today.

okay okay

@ChakshuGautam
Copy link
Owner

@dhruv-1001 sir is this issue open or someone is working? It'd be great if you can assign it to me.

It's almost done by me. I've been a bit busy the past few days due to some reasons but I would do a PR by today.

okay okay

Hey @ALOK9442 would you like to take this issue up instead?

@Sweetdevil144
Copy link
Contributor

Hey @ALOK9442 would you like to take this issue up instead?

I mean, the changes are done by me. All I need to do is push the commits along with a few more changes.

@ALOK9442
Copy link

@dhruv-1001 sir is this issue open or someone is working? It'd be great if you can assign it to me.

It's almost done by me. I've been a bit busy the past few days due to some reasons but I would do a PR by today.

okay okay

Hey @ALOK9442 would you like to take this issue up instead?

yes sir, I would like to take this issue, but @Sweetdevil144 is working on it already.

@Sweetdevil144
Copy link
Contributor

@ChakshuGautam changes pushed.

@ThisisMS11
Copy link

please close the issue is not open any more for others to know .

@Sweetdevil144
Copy link
Contributor

please close the issue is not open any more for others to know .

The issue is still open. The logger has already been initialised and is waiting to be merged.

@chandra-pro
Copy link

heyy @dhruv-1001 This is Chandramani and I am intrested to take this issue as I am proficient in Node JS and have already contributed in Code4Good 2023 program.
Is this issue still open?

@souravbhunia07
Copy link

I am interested in this issue and want to contribute I have knowledge of NodeJS and have a hunger to learn. please assign this issue to me.

@Yash-Sajwan24
Copy link

@dhruv-1001 I understand the problem, and I believe I have the necessary skills. Could I have the opportunity to work on this?

@aryangandhi05
Copy link

Hello @dhruv-1001 Sir i want to solve this issue, as i understand it, and i will give my 100% for solving this issue So please, can you assign me this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment