quick refactor to make a future pull request more focused

We can use `reduce` here to easily get the result of applying the transformations without overwriting the original `email` variable.
InformedK12 · Jun 28, 2016 · e968e39 · e968e39
1 parent 62100ce
commit e968e39
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -7,6 +7,9 @@ TrailingComma:
 AccessModifierIndentation:
   EnforcedStyle: outdent
 
+SingleLineBlockParams:
+  Enabled: false
+
 MethodLength:
   Max: 15
 

diff --git a/lib/email_repair/mechanic.rb b/lib/email_repair/mechanic.rb
@@ -34,9 +34,7 @@ def repair_all(emails)
     def repair(email)
       return unless email
 
-      repairs.each { |repair| email = repair.repair(email) }
-
-      email
+      repairs.reduce(email) { |memo, repair| repair.repair(memo) }
     end
 
     class CommonMistakeRepair