CodeQuality: Lengthen TLD wildcard matching for regex / repair #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What** There are a few cases where longer TLDs are needed beyond the initial 4 characters we allow. A list of all available domain names can be found using: `curl -s http://data.iana.org/TLD/tlds-alpha-by-domain.txt | tail -n+2 | awk '{ print length(), $0 | "sort -n" }'` via the terminal (right now longest is 24, so set it to that).
mockdeep
reviewed
Aug 2, 2017
| @@ -45,7 +45,7 @@ def self.repair(email) | |||
| .gsub(/\s/, '') | |||
| .sub(/@+/, '@') | |||
| .sub(/\.c0m$/, '.com') | |||
| .sub(/,[a-z]{2,4}$/) { |m| m.sub(',', '.') } | |||
| .sub(/,[a-z]{2,24}$/) { |m| m.sub(',', '.') } | |||
There was a problem hiding this comment.
Would be nice to have a more precise check at some point, but this will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There are a few cases where longer TLDs are needed beyond the initial 4 characters
we allow. A list of all available domain names can be found using:
curl -s http://data.iana.org/TLD/tlds-alpha-by-domain.txt | tail -n+2 | awk '{ print length(), $0 | "sort -n" }'via the terminal (right now longest is 24, so set it to that).
Same list is avail here: https://jasontucker.blog/8945/what-is-the-longest-tld-you-can-get-for-a-domain-name