Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More on Wopi-lib and less in wopi-bundle ? #31

Open
julienfastre opened this issue Jan 7, 2023 · 0 comments
Open

More on Wopi-lib and less in wopi-bundle ? #31

julienfastre opened this issue Jan 7, 2023 · 0 comments

Comments

@julienfastre
Copy link
Member

Some code could be located into wopi-lib:

  • the controller does not execute code depending on Symfony (but on PSR-17);

  • the Wopi implementation does depends on some symfony code:

    • find a user and username;
    • store userinfo (on cacheItemPool)

    but those could be made abstracted in wopi-lib

For a more reusable PHP library, we can remove those dependencies and extract some method on an interface, which would be implemented into this bundle.

@julienfastre julienfastre changed the title More on Wopi-lib and less in wopi-bundle More on Wopi-lib and less in wopi-bundle ? Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant